fix reload docker by setting "LINUX_PASSWORD", "PAYARA_ADMIN_PASSWORD… #11463
Conversation
…", "DOMAIN_PASSWORD"
|
Good catch figuring out that the failing passwd command breaks the chain! Thanks for figuring this out! I would prefer handling the error properly by using an or (||) behind the command, making it better comply with shellscript good practices. What do you think? Also, we should probably not just fix it in develop, but also add backports for the last three releases in modules/container-base/src/backports |
pdurbin
added
Size: 3
|
@BenediktMeierUIT thanks for the PR! Please check out Oliver's comment. Also, I added this to next week's agenda for https://ct.gdcc.io. I hope you can make it! |
|
I can’t tell you exactly, as today is my last day and I’ll be on parental leave, and I’m not sure if my contract will be extended afterwards. |
|
Good luck with your little one! If you won't make it, I can take it up from here. Thanks again! |
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
scolapasta
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS Dataverse Project
cmbz
added
FY25 Sprint 23
|
@BenediktMeierUIT it seems I cannot push changes to your PR branch. I am aware that you will probably not read this soon, so I am going to close this PR and create a new one, but include your commits. Thanks for your work on this! |
|
Replaced by this PR: |
3 participants
What this PR does / why we need it:
docker
Which issue(s) this PR closes:
Special notes for your reviewer:
If you normally start the Docker image with docker-compose and Docker is configured to restart all running Docker instances upon a system restart, the error occurs. This happens because the script specifies that if a program does not return exit 0, the script should terminate, and as a result, the entire startup process fails.
Suggestions on how to test this:
During the normal start, all three or at least one of the following parameters must be specified: LINUX_PASSWORD, PAYARA_ADMIN_PASSWORD, DOMAIN_PASSWORD.